aglicacha commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r1022874575
##########
core/src/main/scala/kafka/zk/AdminZkClient.scala:
##########
@@ -355,18 +355,43 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
* @param entityName The entityName of the entityType
* @param configs The config of the entityName
*/
- def changeConfigs(entityType: String, entityName: String, configs:
Properties): Unit = {
+ def changeConfigs(entityType: String, entityName: String, configs:
Properties, isUserClientId: Boolean = false): Unit = {
entityType match {
case ConfigType.Topic => changeTopicConfig(entityName, configs)
case ConfigType.Client => changeClientIdConfig(entityName, configs)
- case ConfigType.User => changeUserOrUserClientIdConfig(entityName,
configs)
+ case ConfigType.User => changeUserOrUserClientIdConfig(entityName,
configs, isUserClientId)
case ConfigType.Broker => changeBrokerConfig(parseBroker(entityName),
configs)
case ConfigType.Ip => changeIpConfig(entityName, configs)
case _ => throw new IllegalArgumentException(s"$entityType is not a
known entityType. Should be one of ${ConfigType.all}")
}
}
+ private def tryCleanQuotaNodes(entityType: String, entityName: String,
isUserClientId: Boolean = false): Boolean = {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
