[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

[GitBox]

mimaison commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1021676801


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java:
##########
@@ -16,23 +16,37 @@
  */
 package org.apache.kafka.connect.mirror;
 
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.CreateTopicsOptions;
 import org.apache.kafka.clients.admin.NewTopic;
 import org.apache.kafka.clients.producer.KafkaProducer;
 import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.common.errors.ClusterAuthorizationException;
+import org.apache.kafka.common.errors.InvalidConfigurationException;
+import org.apache.kafka.common.errors.TimeoutException;
+import org.apache.kafka.common.errors.TopicExistsException;
+import org.apache.kafka.common.errors.UnsupportedVersionException;
 import org.apache.kafka.common.serialization.ByteArrayDeserializer;
 import org.apache.kafka.common.serialization.ByteArraySerializer;
 import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.connect.errors.ConnectException;
 import org.apache.kafka.connect.util.TopicAdmin;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.Arrays;
 import java.util.Map;
 import java.util.List;
 import java.util.HashMap;
 import java.util.Collections;
+import java.util.concurrent.ExecutionException;
 import java.util.regex.Pattern;
 
+import static java.util.Collections.singleton;
+
 /** Internal utility methods. */
 final class MirrorUtils {
+    private static final Logger log = 
LoggerFactory.getLogger(MirrorCheckpointTask.class);

Review Comment:
   `MirrorCheckpointTask` -> `MirrorUtils`



##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##########
@@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {
 
     @Test
     public void testClientConfigProperties() {
+        String clusterABBootstrap = "127.0.0.1:9092, 127.0.0.2:9092";

Review Comment:
   Should it be `clusterABootstrap` instead?



##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##########
@@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {
 
     @Test
     public void testClientConfigProperties() {
+        String clusterABBootstrap = "127.0.0.1:9092, 127.0.0.2:9092";
+        String clusterBBoostrap = "127.0.0.3:9092, 127.0.0.4:9092";

Review Comment:
   `clusterBBoostrap` -> `clusterBBootstrap`



##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##########
@@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {
 
     @Test
     public void testClientConfigProperties() {
+        String clusterABBootstrap = "127.0.0.1:9092, 127.0.0.2:9092";

Review Comment:
   Why are we changing the bootstrap servers ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org