gharris1727 commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1004961482
##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -106,6 +108,7 @@ public Connect startConnect(Map<String, String>
workerProps) {
// Create the admin client to be shared by all backing stores.
Map<String, Object> adminProps = new HashMap<>(config.originals());
ConnectUtils.addMetricsContextProperties(adminProps, config,
kafkaClusterId);
+ adminProps.putIfAbsent(CLIENT_ID_CONFIG, config.groupId() +
"-kafka-cluster-id-lookup");
Review Comment:
nit: this adminclient seems to do a lot more than looking up the kafka
cluster id. It's also responsible for creating internal topics, verifying their
settings, and retrieving end-offsets. perhaps `groupId-shared-admin`?
`groupId-worker-internal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
