OmniaGM commented on PR #12577:
URL: https://github.com/apache/kafka/pull/12577#issuecomment-1287144965

   > > The `MirrorMakerConfigTest` tests the config part, but there's nothing 
that proves that the configured ForwardingAdmin is actually used when creating 
topics, ACLs etc. That might not be difficult to do as an integration test.
   > 
   > I added an integration test called 
`MirrorConnectorsWithCustomForwardingAdminIntegrationTest` that test MM2 with 
`FakeForwardingAdminWithLocalMetadata` that stores the resource metadata in 
`FakeLocalMetadataStore`. The test check that topic and topic's changes are 
persisted in both KafkaCluster and `FakeLocalMetadataStore`. Still working on 
testing ACLs ;however, it has been tricky to set up `EmbeddedConnectCluster` 
with `kafka.security.authorizer.AclAuthorizer`.
   
   Added the last remaining integration test now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to