lucasbru opened a new pull request, #12760:
URL: https://github.com/apache/kafka/pull/12760

   The streams upgrade system inserted FK join code for every version of the 
the StreamsUpgradeTest except for the latest. Also, the original code never 
switched on the `test.run_fk_join` flag for the target version of the upgrade.
   
   The effect was that FK join upgrades were not tested at all, since no FK 
join code was executed after the bounce in the system test.
   
   We introduce `extra_properties` in the system tests, that can be used to 
pass any property to the upgrade driver, which is supposed to be reused by 
system tests for switching on and off flags (e.g. for the state restoration 
code).
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to