[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

[GitBox]

cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r997296305


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##########
@@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() {
 
         final double expectedCloseTaskMetric = 1.0;
         verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics, 
metricName);
-
-        EasyMock.verify(stateManager);
     }
 
     @Test
     public void shouldNotThrowFromStateManagerCloseInCloseDirty() {
-        
EasyMock.expect(stateManager.changelogOffsets()).andStubReturn(Collections.emptyMap());
-        stateManager.close();
-        EasyMock.expectLastCall().andThrow(new 
RuntimeException("KABOOM!")).anyTimes();
-        EasyMock.replay(stateManager);
+        doThrow(new RuntimeException("KABOOM!")).when(stateManager).close();
 
         task = createStandbyTask();
         task.initializeIfNeeded();
 
         task.suspend();
         task.closeDirty();
 
-        EasyMock.verify(stateManager);
+        verify(stateManager, atLeastOnce()).close();
     }
 
     @Test
     public void shouldSuspendAndCommitBeforeCloseClean() {
         stateManager.close();
-        EasyMock.expectLastCall();
+        verify(stateManager, atLeastOnce()).close();
         stateManager.checkpoint();

Review Comment:
   The test should actually look similar to this:
   ```java
   @Test
   public void shouldSuspendAndCommitBeforeCloseClean() {
       when(stateManager.changelogOffsets())
               .thenReturn(Collections.singletonMap(partition, 60L));
       final MetricName metricName = setupCloseTaskMetric();
   
       task = createStandbyTask();
       task.initializeIfNeeded();
       task.suspend();
       task.prepareCommit();
       task.postCommit(true);
       task.closeClean();
   
       assertEquals(Task.State.CLOSED, task.state());
   
       final double expectedCloseTaskMetric = 1.0;
       verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics, 
metricName);
   
       final InOrder stateManagerOrdered = inOrder(stateManager);
       stateManagerOrdered.verify(stateManager).checkpoint();
       stateManagerOrdered.verify(stateManager).close();
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org