guozhangwang commented on code in PR #12650:
URL: https://github.com/apache/kafka/pull/12650#discussion_r973179800
##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -291,8 +297,9 @@ public void shouldSuccessfullyStartWhenLoggingDisabled()
throws InterruptedExcep
assertTrue(startupLatch.await(30, TimeUnit.SECONDS));
}
- @Test
- public void shouldProcessDataFromStoresWithLoggingDisabled() throws
InterruptedException {
+ @ParameterizedTest
Review Comment:
Could we just parameterize the whole class than parameterizing each test
method?
##########
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##########
@@ -239,11 +239,15 @@ public static String safeUniqueTestName(final Class<?>
testClass, final TestName
* Used by tests migrated to JUnit 5.
*/
public static String safeUniqueTestName(final Class<?> testClass, final
TestInfo testInfo) {
- return safeUniqueTestName(testClass,
testInfo.getTestMethod().map(Method::getName).orElse(""));
+ final String displayName = testInfo.getDisplayName();
+ final String methodName =
testInfo.getTestMethod().map(Method::getName).orElse("unknownMethodName");
+ final String testName = displayName.contains(methodName) ? methodName
: methodName + displayName;
+ return safeUniqueTestName(testClass, testName);
+// return safeUniqueTestName(testClass, testInfo.getDisplayName());
Review Comment:
Remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
