[GitHub] [kafka] C0urante commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

[GitBox]

C0urante commented on code in PR #12632:
URL: https://github.com/apache/kafka/pull/12632#discussion_r970105520


##########
core/src/main/scala/kafka/tools/StreamsResetter.java:
##########
@@ -213,8 +217,12 @@ private void parseArguments(final String[] args) {
             .ofType(String.class)
             .describedAs("id")
             .required();
-        bootstrapServerOption = optionParser.accepts("bootstrap-servers", 
"Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2")
-            .withRequiredArg()
+        bootstrapServerOption = optionParser.accepts("bootstrap-server", "The 
server(s) to use for bootstrapping.")

Review Comment:
   Should we use a description that's similar to the one in the console 
producer, which also had a KIP to deprecate a different property in favor of 
`--bootstrap-server`?
   
   Thinking we can copy and tweak from here: 
https://github.com/apache/kafka/blob/7b49f175b964c468d5ca7ac9bd70dfd72e6a2e4e/core/src/main/scala/kafka/tools/ConsoleProducer.scala#L135



##########
docs/streams/developer-guide/app-reset-tool.html:
##########
@@ -84,9 +84,11 @@ <h2>Step 1: Run the application reset tool<a 
class="headerlink" href="#step-1-ru
 ---------------------                 -----------
 * --application-id &lt;String: id&gt;       The Kafka Streams application ID
                                         (application.id).
---bootstrap-servers &lt;String: urls&gt;    Comma-separated list of broker 
urls with
-                                        format: HOST1:PORT1,HOST2:PORT2
-                                        (default: localhost:9092)
+--bootstrap-server [String: Server(s)  The server(s) to use for bootstrapping.

Review Comment:
   Can we keep the formatting consistent with the other options here, using 
`<...>` instead of `[...]`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org