[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

[GitBox]

clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968206590


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() {
         topologyMetadata.pauseTopology(UNNAMED_TOPOLOGY);
 
         assertEquals(taskManager.notPausedTasks().size(), 0);
+
+        verifyConsumerResumedWithAssignment(consumer);

Review Comment:
   The below function set an expectation for a function which was not stubbed:
   ```
   private static void expectRestoreToBeCompleted(final Consumer<byte[], 
byte[]> consumer,
                                                      final ChangelogReader 
changeLogReader,
                                                      final boolean 
changeLogUpdateRequired) {
           final Set<TopicPartition> assignment = singleton(new 
TopicPartition("assignment", 0));
           expect(consumer.assignment()).andReturn(assignment);
           consumer.resume(assignment); <--- THIS IS THE EXPECTATION
           expectLastCall();
           
expect(changeLogReader.completedChangelogs()).andReturn(emptySet()).times(changeLogUpdateRequired
 ? 1 : 0, 1);
   }
   ```
   I wanted to keep this verification so I moved it to a separate function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org