cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964174732
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -685,6 +691,7 @@ private void recycleTask(final Task task,
final Map<TaskId, RuntimeException>
taskExceptions) {
Task newTask = null;
try {
+ task.suspend();
Review Comment:
`recycleTask()` is only called from the code path that uses the state
updater and in that code path we do not suspend active tasks on revocation. The
only place we suspend tasks (active and standbys) coming from the state updater
is here. In the code path without state updater, standbys are suspended before
recycling but that code path is not executed with state updater enabled. During
shutdown and error handling tasks are suspended in the code path that is
executed with and without state updater.
So I think the answer to your questions is "no" and "no".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
