yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r962111245
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java:
##########
@@ -268,8 +275,12 @@ void backoff(int attempt, long deadline) {
if (delay + time.milliseconds() > deadline) {
delay = deadline - time.milliseconds();
Review Comment:
I guess it isn't impossible although extremely unlikely? I can add logic to
set a min delay of 0 here, but I'm not sure I understand how we'd go about
testing that? 🤔
Another option (which seems preferable) would be to not call
`time.milliseconds()` twice - store it in a variable `currentTime` and use it
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
