[ 
https://issues.apache.org/jira/browse/KAFKA-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585384#comment-17585384
 ] 

Yash Mayya commented on KAFKA-14015:
------------------------------------

Hm this looks like it maybe a bug in the StandaloneHerder. In the 
DistributedHerder, [restartConnector calls 
startConnector|https://github.com/apache/kafka/blob/38103ffaa962ef5092baffb884c84f8de3568501/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java#L1023]
 after stopping the connector which then gets the latest connector config (i.e. 
after substituting all variable configs with their values from the config 
transformer). It then asks the connector to supply it with a new set of task 
configs, and then if it detects that the task configs have changed, it will 
write the new task configs to the config topic or forward it to the leader if 
it isn't the leader (which then eventually results in the old set of tasks 
being stopped and the new tasks being started).

> ConfigProvider with ttl fails to restart tasks
> ----------------------------------------------
>
>                 Key: KAFKA-14015
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14015
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ross Lawley
>            Assignee: Sagar Rao
>            Priority: Major
>
> According to the 
> [KIP-297|https://cwiki.apache.org/confluence/display/KAFKA/KIP-297%3A+Externalizing+Secrets+for+Connect+Configurations#KIP297:ExternalizingSecretsforConnectConfigurations-SecretRotation]:
> {quote} * When the Herder receives the onChange() call, it will check a new 
> connector configuration property config.reload.action which can be one of the 
> following:
>  ** The value restart, which means to schedule a restart of the Connector and 
> all its Tasks. This will be the default.
>  ** The value none, which means to do nothing.{quote}
> However, the 
> [restartConnector|https://github.com/apache/kafka/blob/3.2.0/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java#L287-L294]
>  method only restarts the connector and does not restart any tasks.  Suggest 
> calling {{restartConnectorAndTasks}} instead.
> The result is changed configurations provided by the ConfigProvider are not 
> picked up and existing tasks continue to use outdated configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to