divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952561099
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private final String connector = "connector";
private final ConnectorClientConfigOverridePolicy
noneConnectorClientConfigOverridePolicy = new
NoneConnectorClientConfigOverridePolicy();
- @MockStrict private Worker worker;
- @MockStrict private WorkerConfigTransformer transformer;
- @MockStrict private ConfigBackingStore configStore;
- @MockStrict private StatusBackingStore statusStore;
- @MockStrict private ClassLoader classLoader;
+ @Mock private Worker worker;
+ @Mock private WorkerConfigTransformer transformer;
+ @Mock private ConfigBackingStore configStore;
+ @Mock private StatusBackingStore statusStore;
+ @Mock private ClassLoader classLoader;
@Mock private Plugins plugins;
+ private ClassLoader loader;
+ private Connector insConnector;
Review Comment:
The naming is an artifact of the commits I merged from previous commits
which I took over. But you are right. I have renamed these variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
