dengziming commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r946492715


##########
raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java:
##########
@@ -107,6 +107,8 @@ public synchronized void handleCommit(BatchReader<Integer> 
reader) {
             }
             log.debug("Counter incremented from {} to {}", initialCommitted, 
committed);
 
+            // A snapshot is being taken here too, not being able to -
+            // `import org.apache.kafka.metadata.utils.SnapshotReason`, figure 
out why?

Review Comment:
   Here we already logged the reason: "the previoud snapshot includes {}", 
please remove the new comments and help to fix the typo "previoud".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to