cmccabe commented on code in PR #12455:
URL: https://github.com/apache/kafka/pull/12455#discussion_r932720750
##########
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##########
@@ -38,6 +38,33 @@ object PasswordEncoder {
val IterationsProp = "iterations"
val EncyrptedPasswordProp = "encryptedPassword"
val PasswordLengthProp = "passwordLength"
+
+ def encrypting(secret: Password,
+ keyFactoryAlgorithm: Option[String],
+ cipherAlgorithm: String,
+ keyLength: Int,
+ iterations: Int): EncryptingPasswordEncoder = {
+ new EncryptingPasswordEncoder(secret, keyFactoryAlgorithm,
cipherAlgorithm, keyLength, iterations)
+ }
+
+ def passthrough(): PassthroughPasswordEncoder = {
+ new PassthroughPasswordEncoder()
+ }
+}
+
+trait PasswordEncoder {
+ def encode(password: Password): String
+ def decode(encodedPassword: String): Password
+
+ private[utils] def base64Decode(encoded: String): Array[Byte] =
Base64.getDecoder.decode(encoded)
+}
+
+/**
+ * A password encoder that does not modify the given password. This is used in
KRaft mode only.
Review Comment:
hmm, not sure about "passthrough". how do you like `NoOpPasswordEncoder` as
a name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
