cadonna commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925917621
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java:
##########
@@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() {
log.info("Closed clean and recycled state");
}
+ /**
+ * Create an active task from this standby task without closing and
re-initializing the state stores.
+ * The task should have been in suspended state when calling this function
+ *
+ * TODO: we should be able to not need the input partitions as input param
in future but always reuse
+ * the task's input partitions when we have fixed partitions ->
tasks mapping
+ */
+ public StreamTask recycle(final Time time,
Review Comment:
Yeah, I was also wondering if we can simplify this chain of calls from
`TaskManager` -> `Tasks` -> `StandbyTaskCreator`/`ActiveTaskCreator` ->
`StreamTask`/`StandbyTask`. And I also thought it might be better to postpone
this refactoring. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
