showuon commented on PR #12349: URL: https://github.com/apache/kafka/pull/12349#issuecomment-1188561057
@aiquestion , since we already fixed the bug and other comments are just refactoring it, I think we can fix the broken tests and merge it for now. And then you create a follow-up PR to address my other comments. Is that OK for you? Or you'd like to address all my comments right away, which is also good to me. PS. The failed tests can be fixed by addressing this comment: https://github.com/apache/kafka/pull/12349#discussion_r924022486 . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
