fvaleri commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183073005
> Nice catch! One question: the original image has "kafka log implementation" title on top of it. Did you intend to remove it? I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference. > Also, in the image, it should be "my-topic-0/344...log", right? Not sure if this image should be consistent with the "my-topic" name. Or at least, there should be appending the partition index at the end of topic, ex: "topic-0/344...log", right? This an image that can be easily reused in similar contexts, even externally. It's pretty hard to make it consistent with text, so I'm only addressing Kafka implementation consistency here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
