mjsax commented on code in PR #12383:
URL: https://github.com/apache/kafka/pull/12383#discussion_r915090310
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -1256,44 +1255,6 @@ public void
shouldThrowExceptionWhenClientTagValueExceedMaxLimit() {
);
}
- @Test
- @SuppressWarnings("deprecation")
- public void
shouldUseStateStoreCacheMaxBytesWhenBothOldAndNewConfigsAreSet() {
- props.put(StreamsConfig.STATESTORE_CACHE_MAX_BYTES_CONFIG, 100);
- props.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 10);
- final StreamsConfig config = new StreamsConfig(props);
- assertEquals(getTotalCacheSize(config), 100);
- }
-
- @Test
- @SuppressWarnings("deprecation")
- public void
shouldUseCacheMaxBytesBufferingConfigWhenOnlyDeprecatedConfigIsSet() {
- props.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 10);
- final StreamsConfig config = new StreamsConfig(props);
- assertEquals(getTotalCacheSize(config), 10);
- }
-
- @Test
- public void shouldUseStateStoreCacheMaxBytesWhenNewConfigIsSet() {
- props.put(StreamsConfig.STATESTORE_CACHE_MAX_BYTES_CONFIG, 10);
- final StreamsConfig config = new StreamsConfig(props);
- assertEquals(getTotalCacheSize(config), 10);
- }
-
- @Test
- public void
shouldUseDefaultStateStoreCacheMaxBytesConfigWhenNoConfigIsSet() {
- final StreamsConfig config = new StreamsConfig(props);
- assertEquals(getTotalCacheSize(config), 10 * 1024 * 1024);
- }
-
- @Test
- public void testInvalidSecurityProtocol() {
- props.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, "abc");
- final ConfigException ce = assertThrows(ConfigException.class,
- () -> new StreamsConfig(props));
-
assertTrue(ce.getMessage().contains(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG));
- }
-
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
