cadonna commented on code in PR #12379:
URL: https://github.com/apache/kafka/pull/12379#discussion_r913695625
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -922,7 +914,6 @@ private void verifyRestoredActiveTasks(final StreamTask...
tasks) throws Excepti
VERIFICATION_TIMEOUT,
"Did not get all restored active task within the given
timeout!"
);
- assertTrue(restoredTasks.stream().allMatch(task -> task.state() ==
State.RESTORING));
Review Comment:
It doesn't make sense to verify the state of a mock task, because the mock
will always return what we specified it should return independently of what the
state updater does with the task. Totally missed that until now 🙂 !
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -956,10 +947,6 @@ private void verifyUpdatingTasks(final Task... tasks)
throws Exception {
VERIFICATION_TIMEOUT,
"Did not get all updating task within the given timeout!"
);
- assertTrue(updatingTasks.stream()
- .allMatch(task -> task.isActive() && task.state() ==
State.RESTORING
- ||
- !task.isActive() && task.state() == State.RUNNING));
Review Comment:
See above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
