cadonna commented on code in PR #12344:
URL: https://github.com/apache/kafka/pull/12344#discussion_r909295030


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -366,6 +364,8 @@ public void start() {
             stateUpdaterThread.start();
             shutdownGate = new CountDownLatch(1);
         }
+        // initialize the last commit as of now to prevent first commit 
happens immediately
+        this.lastCommitMs = time.milliseconds();

Review Comment:
   Shouldn't this go inside the `if`-branch? Otherwise it would be possible to 
change the last committed time of already started state updaters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to