C0urante commented on code in PR #11782:
URL: https://github.com/apache/kafka/pull/11782#discussion_r908449523
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java:
##########
@@ -174,8 +174,6 @@ protected void producerSendFailed(
);
commitTaskRecord(preTransformRecord, null);
} else {
- log.error("{} failed to send record to {}: ",
WorkerSourceTask.this, topic, e);
- log.trace("{} Failed record: {}", WorkerSourceTask.this,
preTransformRecord);
producerSendException.compareAndSet(null, e);
Review Comment:
The `TRACE`-level message is still [logged by the
superclass](https://github.com/C0urante/kafka/blob/8ed7592f11f842fc2827a69008d1df3f34f36c78/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java#L401-L407),
and the `ERROR`-level message is still logged at `ERROR` level if the producer
hasn't yet been closed. If the producer has been closed, the error is not worth
logging at higher than `TRACE` since closing a producer causes all of its
in-flight callbacks to complete with an error and the resulting noise to signal
ratio is quite high..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
