[GitHub] [kafka] dajac commented on a diff in pull request #12308: KAFKA-14009: update rebalance timeout in memory when consumers use st…

Tue, 28 Jun 2022 05:35:09 -0700 


dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r908422658


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1294,7 +1296,7 @@ class GroupCoordinator(val brokerId: Int,
     supportSkippingAssignment: Boolean
   ): Unit = {
     val currentLeader = group.leaderOrNull
-    val member = group.replaceStaticMember(groupInstanceId, oldMemberId, 
newMemberId)
+    val member = group.replaceStaticMember(groupInstanceId, oldMemberId, 
newMemberId, rebalanceTimeoutMs)

Review Comment:
   Did you consider updating the rebalance timeout via the `updateMember` 
method instead of this one? It feels a bit weird to replace and update the 
member here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to