hachikuji commented on code in PR #12345:
URL: https://github.com/apache/kafka/pull/12345#discussion_r906510006
##########
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala:
##########
@@ -18,42 +18,41 @@
package kafka.server
import scala.collection.Seq
-
-import org.junit.jupiter.api.{AfterEach, BeforeEach, Test, TestInfo}
-import kafka.server.QuorumTestHarness
-import kafka.utils.TestUtils
+import org.junit.jupiter.api.AfterEach
+import kafka.utils.{TestInfoUtils, TestUtils}
import TestUtils._
+import kafka.integration.KafkaServerTestHarness
import org.apache.kafka.clients.producer.ProducerRecord
import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.serialization.StringSerializer
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
-class ReplicaFetchTest extends QuorumTestHarness {
- var brokers: Seq[KafkaServer] = null
+class ReplicaFetchTest extends KafkaServerTestHarness {
Review Comment:
Perhaps we could extend from `IntegrationTestHarness` instead? Then we just
need to override `brokerCount` and we can get rid of the `generateConfigs`
override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
