cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r905199552
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -1945,6 +1945,22 @@ public void
shouldCheckpointOnCloseRestoringIfNoProgress() {
EasyMock.verify(stateManager);
}
+ @Test
+ public void shouldCheckpointState() {
+ stateManager.flush();
+ EasyMock.expectLastCall().once();
+ stateManager.checkpoint();
+ EasyMock.expectLastCall().once();
+ EasyMock.replay(stateManager);
+
+ task = createOptimizedStatefulTask(createConfig("100"), consumer);
+
+ task.initializeIfNeeded();
+ task.maybeCheckpoint(true);
Review Comment:
Do we not need to also test `task.maybeCheckpoint(false)`?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -313,6 +337,7 @@ public void
shouldRestoreActiveStatefulTaskThenUpdateStandbyTaskAndAgainRestoreA
stateUpdater.add(task2);
verifyRestoredActiveTasks(task1);
+ verifyCheckpointTasks(true, task1);
Review Comment:
I think we need another verification before line 350.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##########
@@ -206,6 +206,47 @@ public void shouldThrowIfCommittingOnIllegalState() {
assertThrows(IllegalStateException.class, task::prepareCommit);
}
+
+ @Test
+ public void shouldAlwaysCheckpointStateIfEnforced() {
+ stateManager.flush();
+ EasyMock.expectLastCall().once();
+ stateManager.checkpoint();
+ EasyMock.expectLastCall().once();
+
EasyMock.expect(stateManager.changelogOffsets()).andReturn(Collections.emptyMap()).anyTimes();
+ EasyMock.replay(stateManager);
+
+ task = createStandbyTask();
+
+ task.initializeIfNeeded();
+ task.maybeCheckpoint(true);
+
+ EasyMock.verify(stateManager);
+ }
+
+ @Test
+ public void shouldOnlyCheckpointStateWithBigAdvanceIfNotEnforced() {
+
EasyMock.expect(stateManager.changelogOffsets()).andStubReturn(Collections.emptyMap());
+ stateManager.flush();
+ EasyMock.expectLastCall();
+ stateManager.checkpoint();
+ EasyMock.expectLastCall().once();
+ EasyMock.expect(stateManager.changelogOffsets())
+ .andReturn(Collections.singletonMap(partition, 50L))
+ .andReturn(Collections.singletonMap(partition, 11000L))
+ .andReturn(Collections.singletonMap(partition, 11000L));
+ EasyMock.replay(stateManager);
+
+ task = createStandbyTask();
+ task.initializeIfNeeded();
+
+ task.maybeCheckpoint(false); // this should not checkpoint
+ task.maybeCheckpoint(false); // this should checkpoint
+ task.maybeCheckpoint(false); // this should not checkpoint
Review Comment:
This test is not really clear about when the checkpointing happens. Ideally,
we would need to verify after each call to `maybeCheckpoint()`. That might be
possible with `EasyMock#reset()` but I am not 100% sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
