MPeli opened a new pull request, #12331:
URL: https://github.com/apache/kafka/pull/12331

   Hi,
   
     I have come across [this 
comment](https://issues.apache.org/jira/browse/KAFKA-2170?focusedCommentId=17477226&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17477226)
 by [Maksim 
Zinal](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mzinal).
   
   > I've created a quick patch which seems to fix the issue on my system and 
on the Kafka version I use (2.8.0).
   > 
   > I believe that the reason of lock failures is the use of RandomAccessFile 
Java API to open the files in some cases, while in other cases 
FileChannel.open() is used instead. When opening files with RandomAccessFile 
under Windows, FILE_SHARE_DELETE flag is not set, which leads to "access 
denied" errors when trying to rename or delete the open files. 
FileChannel.open() sets the FILE_SHARE_DELETE by default, as I checked on JDK 8 
and 11.
   > 
   > Here's the link to the branch based on tag 2.8.0: 
https://github.com/zinal/kafka/tree/2.8.0_KAFKA-1194
   > 
   > Here are the exact changes implemented: 
https://github.com/zinal/kafka/compare/2.8.0...zinal:2.8.0_KAFKA-1194 (plus 
jcenter and grgit stuff needed to run the build).
   
   This change addresses some "access denied" error which occur on Windows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to