cadonna commented on code in PR #12209:
URL: https://github.com/apache/kafka/pull/12209#discussion_r902486138
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java:
##########
@@ -29,12 +29,8 @@
import org.apache.kafka.streams.processor.api.ProcessorContext;
import org.apache.kafka.streams.processor.api.ProcessorSupplier;
import org.apache.kafka.streams.processor.api.Record;
-import org.junit.Rule;
-import org.junit.rules.Timeout;
public class SmokeTestUtil {
- @Rule
- public Timeout globalTimeout = Timeout.seconds(600);
Review Comment:
Had to remove this since system tests do not have a dependency to junit that
contains`Timeout` which led to `ClassNotFoundException` during system test
executions. AFAICS, the timeout rule makes no sense here since this class and
all child-classes except `RelationalSmokeTestTest` do not contain tests. I
added the timeout rule to `RelationalSmokeTestTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
