dengziming commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1161178784

   @hachikuji In this PR I tried your suggestion and it does solve this 
problem, however, this will make the logic in RaftClient very complex and we 
need to save more states in `LeaderState` and it's also difficult to test. I 
made another solution according to how we add a follow replica into ISR to 
check `followerEndOffset >= leaderLog.highWatermark`.
   
   here is the code change: 
https://github.com/dengziming/kafka/pull/new/KAFKA-13959-2, @showuon @hachikuji 
 WDYT?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to