cmccabe opened a new pull request, #12315: URL: https://github.com/apache/kafka/pull/12315
This PR allows us to support connecting the metadata shell to a live KRaft quorum via --controller, as specified in the original KIPs. In order to do this, the PR factors out a "MetadataShellSource" interface which is implemented by both a snapshot file and a live quorum. Previously, the "shell" gradle submodule dependend on "core." This extended the gradle build time because "core" takes a long time to build. It also tended to reduce the encapsulation of the shell. This PR makes "core" depend on "shell" instead. In order to support this, the new entry point for the tool is kafka.tools.MetadataShellTool rather than org.apache.kafka.shell.MetadataShell. RaftManager.scala: make close() idempotent, as it is for nearly everything else. This makes cleanup logic easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
