vamossagar12 opened a new pull request, #12309: URL: https://github.com/apache/kafka/pull/12309
The [HeaderConverter interface](https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/connect/api/src/main/java/org/apache/kafka/connect/storage/HeaderConverter.java#L27) extends Closeable, but HeaderConverter::close is never actually invoked anywhere. We can and should start invoking it, probably wrapped in [Utils::closeQuietly](https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/clients/src/main/java/org/apache/kafka/common/utils/Utils.java#L999-L1010) so that any invalid logic in that method for custom header converters that has to date gone undetected will not cause new task failures. This PR addresses the above concern by invoking HeaderConverter.close in cases of shutdowns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
