guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900315653
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -286,6 +308,7 @@ public void
shouldRestoreActiveStatefulTasksAndUpdateStandbyTasks() throws Excep
stateUpdater.add(task4);
verifyRestoredActiveTasks(task2, task1);
+ verifyCommitTasks(true, task2, task1);
Review Comment:
Yes, unless we wait for commit interval.. btw I think since this is already
covered in other tests we do not need to wait (and since it's system time we
need to wait conservatively to reduce flakiness) again in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
