C0urante commented on code in PR #12291: URL: https://github.com/apache/kafka/pull/12291#discussion_r896810101
########## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectResource.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.runtime.rest.resources; + +import java.util.concurrent.TimeUnit; + +/** + * This interface defines shared logic for all Connect REST resources. + */ +public interface ConnectResource { + + // TODO: This should not be so long. However, due to potentially long rebalances that may have to wait a full + // session timeout to complete, during which we cannot serve some requests. Ideally we could reduce this, but + // we need to consider all possible scenarios this could fail. It might be ok to fail with a timeout in rare cases, + // but currently a worker simply leaving the group can take this long as well. + long DEFAULT_REST_REQUEST_TIMEOUT_MS = TimeUnit.SECONDS.toMillis(90); Review Comment: It might be time to revisit that TODO, but I was only copying the comment and value from an existing part of the code base: https://github.com/apache/kafka/blob/4fcfd9ddc4a8da3d4cfbb69268c06763352e29a9/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java#L84-L88 FWIW I haven't heard too much fuss about the REST request timeout to date; the only time that timeouts have been an issue in my experience is when the worker is completely hosed because its herder thread is blocked on something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
