clolov opened a new pull request, #12285: URL: https://github.com/apache/kafka/pull/12285
This is the first part of KAFKA-7342 (https://issues.apache.org/jira/browse/KAFKA-7342). Here are the decisions I made in this change: * Do not (yet) migrate files using Parameterized because they require more in-depth changes. A list of the files which I haven't changed can be found here (1). * Prefix assertTrue, assertFalse, assertNull etc. with Assertions. * Run IntelliJ's Optimize Imports and streams:spotlessApply on the streams module. 1. List of untouched tests. Once these are migrated then JUnit4 should no longer be used in Kafka Streams streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/PositionRestartIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreatorTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingWindowBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/MergedSortedCacheWrappedWindowStoreIteratorTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedSegmentedBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/SessionStoreFetchTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilderTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreFetchTest.java streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/ResetPartitionTimeIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/TableTableJoinIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java streams/src/test/java/org/apache/kafka/streams/integration/EosV2UpgradeIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/KTableEfficientRangeQueryTest.java streams/src/test/java/org/apache/kafka/streams/integration/RangeQueryIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/SuppressionDurabilityIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregateTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreToProcessorContextAdapterTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/TimestampedKeyValueStoreMaterializerTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueIteratorFacadeTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/MergedSortedCacheWrappedWindowStoreKeyValueIteratorTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBSegmentedBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionTopicsTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyKeyValueStoreFacadeTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBSessionStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/SessionKeySchemaTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBufferTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/WindowKeySchemaTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/integration/TimeWindowedKStreamIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingTimestampedWindowBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ListValueStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreFacadeTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowSegmentedBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/SessionStoreBuilderTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
