[
https://issues.apache.org/jira/browse/KAFKA-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368487#comment-16368487
]
ASF GitHub Bot commented on KAFKA-6554:
---------------------------------------
hachikuji opened a new pull request #4585: KAFKA-6554; Missing lastOffsetDelta
validation before log append
URL: https://github.com/apache/kafka/pull/4585
Add validation checks that the offset range is valid and aligned with the
batch count prior to appending to the log. I've added several unit tests to
verify the various invalid cases.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Broker doesn't reject Produce request with inconsistent state
> -------------------------------------------------------------
>
> Key: KAFKA-6554
> URL: https://issues.apache.org/jira/browse/KAFKA-6554
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 1.0.0
> Reporter: Simon Fell
> Assignee: Jason Gustafson
> Priority: Minor
> Attachments: produce_v3.txt
>
>
> Produce messages of type v3 have offset deltas in each record along with a
> LastOffsetDelta for the topic/partition set. In investigating an issue with
> missing offsets, I found a bug in a producer library where it would send
> multiple records, but leave LastOffsetDelta at 0. This causes various
> problems including holes in the offsets fetched by the consumer.
> As lastOffsetDelta can be computed by looking at the records, it seems like
> the broker should at least validate the LastOffsetDelta field against the
> contained records to stop this bad data getting in.
> I've attached a decode v3 produce message that was causing the problems, and
> was accepted by the broker.
> Here's a link to the issue in the kafka library we were using which has more
> context if you need it.
> https://github.com/Shopify/sarama/issues/1032
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
