ijuma commented on code in PR #12276:
URL: https://github.com/apache/kafka/pull/12276#discussion_r893705374
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -1953,6 +1935,7 @@ class ReplicaManagerTest {
val mockLogMgr: LogManager = mock(classOf[LogManager])
when(mockLogMgr.liveLogDirs).thenReturn(config.logDirs.map(new
File(_).getAbsoluteFile))
when(mockLogMgr.getOrCreateLog(ArgumentMatchers.eq(topicPartitionObj),
ArgumentMatchers.eq(false), ArgumentMatchers.eq(false),
any())).thenReturn(mockLog)
+// when(mockLogMgr.getLog(topicPartitionObj, isFuture =
false)).thenReturn(Some(mockMergedLog))
Review Comment:
No :) The test doesn't pass unless this is commented out. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
