acsaki commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1150937597
Thanks @showuon , I really like the idea that we should set `sessionExpirationTimeNanos` regardless whether max reauth is set or not, otherwise clients probably won't get disconnected after their tokens expire. Maybe the original intention was to still allow the clients to re-authenticate but nothing else? Feels safer this way. Regarding whether max reauth is in play, I realized that the null check might not be not enough, we should probably treat it being the default 0L the same. (I think max reauth = 0 doesn't really make sense, does it?) So I've updated the PR and now it checks `connectionsMaxReauthMs != null && connectionsMaxReauthMs > 0` where there was only a null check. Tons of failing tests turned green instantly. Does this make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
