mimaison commented on code in PR #11779:
URL: https://github.com/apache/kafka/pull/11779#discussion_r891478789
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java:
##########
@@ -320,6 +320,18 @@ public void putTaskConfigs(final @PathParam("connector")
String connector,
completeOrForwardRequest(cb, "/connectors/" + connector + "/tasks",
"POST", headers, taskConfigs, forward);
}
+ @PUT
+ @Path("/{connector}/fence")
+ public Response fenceZombies(final @PathParam("connector") String
connector,
+ final @Context HttpHeaders headers,
+ final @QueryParam("forward") Boolean forward,
+ final byte[] requestBody) throws Throwable {
+ FutureCallback<Void> cb = new FutureCallback<>();
+ herder.fenceZombies(connector, cb,
InternalRequestSignature.fromHeaders(requestBody, headers));
+ completeOrForwardRequest(cb, "/connectors/" + connector + "/fence",
"PUT", headers, requestBody, forward);
+ return Response.ok().build();
Review Comment:
As far as I can tell the other internal endpoint returns 204 so I'd be in
favor of doing the same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
