mumrah commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r891371390
########## metadata/src/main/resources/common/metadata/BrokerRegistrationChangeRecord.json: ########## @@ -17,14 +17,16 @@ "apiKey": 17, "type": "metadata", "name": "BrokerRegistrationChangeRecord", - "validVersions": "0", + "validVersions": "0-1", Review Comment: I actually think we should not increase the record version unless there is an incompatible change. To my knowledge, that is what the record version has conveyed historically. However, I don't think there's any _harm_ in increasing it, and I also don't think we need to solve it in this PR. Let's go with Colin's suggestion here and we can continue this discussion on the mailing list or offline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
