dajac commented on code in PR #12240:
URL: https://github.com/apache/kafka/pull/12240#discussion_r889832039
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -132,15 +143,27 @@ ClusterControlManager build() {
replicaPlacer = new StripedReplicaPlacer(new Random());
}
if (controllerMetrics == null) {
- throw new RuntimeException("You must specify
controllerMetrics");
+ throw new RuntimeException("You must specify
ControllerMetrics");
+ }
+ if (featureControl == null) {
+ featureControl = new FeatureControlManager.Builder().
+ setLogContext(logContext).
+ setSnapshotRegistry(snapshotRegistry).
+ setQuorumFeatures(new QuorumFeatures(0, new ApiVersions(),
+ QuorumFeatures.defaultFeatureMap(),
+ singletonList(0))).
+ setMetadataVersion(MetadataVersion.latest()).
+ build();
Review Comment:
I followed what we did in the `ReplicationControlManager` as part of
https://github.com/apache/kafka/commit/65b4374203608dc4d68544bde16d4acd2e31efd1.
I am fine either ways but I think that we should be consistent in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
