ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r887355518
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##########
@@ -56,6 +61,26 @@ public void addChild(final ProcessorNode<Void, Void, ?, ?>
child) {
@Override
public void init(final InternalProcessorContext<Void, Void> context) {
+ // It is important to first create the sensor before calling init on
the
+ // parent object. Otherwise due to backwards compatibility an empty
sensor
+ // without parent is created with the same name.
+ // Once the backwards compatibility is not needed anymore it might be
possible to
+ // change this.
Review Comment:
Ah yeah I was wondering about it but I hoped you'd see this and remember the
context. I'll remove the comment from my PR and we can follow up separately if
it needs to be removed from the `SourceNode` class (where I copied it from, yes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
