[jira] [Commented] (KAFKA-5660) Don't throw TopologyBuilderException during runtime

[Matthias J. Sax (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366448#comment-16366448
 ] 

Matthias J. Sax commented on KAFKA-5660:
----------------------------------------

Thanks, [~nafshartous]. I updated the description.

> Don't throw TopologyBuilderException during runtime
> ---------------------------------------------------
>
>                 Key: KAFKA-5660
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5660
>             Project: Kafka
>          Issue Type: Task
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Nick Afshartous
>            Priority: Major
>
> {{TopologyBuilderException}} is a pre-runtime exception that should only be 
> thrown before {{KafkaStreams#start()}} is called.
> However, we do throw {{TopologyBuilderException}} within
>  - `SourceNodeFactory#getTopics`
>  - `ProcessorContextImpl#getStateStore`
>  - `StreamPartitionAssignor#prepareTopic `
> (and maybe somewhere else: we should double check if there are other places 
> in the code like those).
> We should replace those exception with either {{StreamsException}} or with a 
> new exception type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)