[
https://issues.apache.org/jira/browse/KAFKA-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361153#comment-16361153
]
ASF GitHub Bot commented on KAFKA-6552:
---------------------------------------
guozhangwang closed pull request #4556: KAFKA-6552:“entity_type” not exactly
in description of kafka-configs.sh
URL: https://github.com/apache/kafka/pull/4556
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/scala/kafka/admin/ConfigCommand.scala
b/core/src/main/scala/kafka/admin/ConfigCommand.scala
index b18dcc99937..dfaaa51139c 100644
--- a/core/src/main/scala/kafka/admin/ConfigCommand.scala
+++ b/core/src/main/scala/kafka/admin/ConfigCommand.scala
@@ -296,10 +296,10 @@ object ConfigCommand extends Config {
val nl = System.getProperty("line.separator")
val addConfig = parser.accepts("add-config", "Key Value pairs of configs
to add. Square brackets can be used to group values which contain commas:
'k1=v1,k2=[v1,v2,v2],k3=v3'. The following is a list of valid configurations: "
+
- "For entity_type '" + ConfigType.Topic + "': " +
LogConfig.configNames.map("\t" + _).mkString(nl, nl, nl) +
- "For entity_type '" + ConfigType.Broker + "': " +
DynamicConfig.Broker.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
- "For entity_type '" + ConfigType.User + "': " +
DynamicConfig.User.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
- "For entity_type '" + ConfigType.Client + "': " +
DynamicConfig.Client.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
+ "For entity-type '" + ConfigType.Topic + "': " +
LogConfig.configNames.map("\t" + _).mkString(nl, nl, nl) +
+ "For entity-type '" + ConfigType.Broker + "': " +
DynamicConfig.Broker.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
+ "For entity-type '" + ConfigType.User + "': " +
DynamicConfig.User.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
+ "For entity-type '" + ConfigType.Client + "': " +
DynamicConfig.Client.names.asScala.map("\t" + _).mkString(nl, nl, nl) +
s"Entity types '${ConfigType.User}' and '${ConfigType.Client}' may
be specified together to update config for clients of a specific user.")
.withRequiredArg
.ofType(classOf[String])
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> “entity_type” not exactly in description of kafka-configs.sh
> -------------------------------------------------------------
>
> Key: KAFKA-6552
> URL: https://issues.apache.org/jira/browse/KAFKA-6552
> Project: Kafka
> Issue Type: Bug
> Components: admin
> Affects Versions: 0.11.0.2
> Reporter: Xin
> Priority: Trivial
>
> There are some “entity_type” in the description of the command option
> “--add-config”, but the “--entity-type ” is the command option of
> kafka-configs.sh
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
