[
https://issues.apache.org/jira/browse/KAFKA-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295749#comment-16295749
]
ASF GitHub Bot commented on KAFKA-6328:
---------------------------------------
GitHub user ConcurrencyPractitioner opened a pull request:
https://github.com/apache/kafka/pull/4339
[KAFKA-6328] Exclude node groups belonging to global stores in
InternalTopologyBuilder#makeNodeGroups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConcurrencyPractitioner/kafka kafka-6238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4339
----
commit ab7531552c9e830ad87f06132f45b3257a3632fa
Author: RichardYuSTUG <yohan.richard....@gmail.com>
Date: 2017-12-18T22:01:02Z
[KAFKA-6328] Exclude node groups belonging to global stores in
InternalTopologyBuilder
commit 42ea1f0e885eda70b60712ded801ba010a9a2c7e
Author: RichardYuSTUG <yohan.richard....@gmail.com>
Date: 2017-12-18T22:07:58Z
Testing
commit da2bf85318db465b325383ecded9b51474f1d35b
Author: RichardYuSTUG <yohan.richard....@gmail.com>
Date: 2017-12-18T22:09:10Z
[KAFKA-6328] Exclude node groups belonging to global stores in
InternalTopologyBuilder#makeNodeGroups
----
> Exclude node groups belonging to global stores in
> InternalTopologyBuilder#makeNodeGroups
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-6328
> URL: https://issues.apache.org/jira/browse/KAFKA-6328
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 1.0.0
> Reporter: Guozhang Wang
> Assignee: Richard Yu
> Labels: newbie
> Attachments: kafka-6328.diff
>
>
> Today when we group processor nodes into groups (i.e. sub-topologies), we
> assign the sub-topology id for global tables' dummy groups as well. As a
> result, the subtopology ids (and hence task ids) are not consecutive anymore.
> This is quite confusing for users trouble shooting and debugging; in
> addition, the node group for global stores are not useful as well: we simply
> exclude it in all the caller functions of makeNodeGroups.
> It would be better to simply exclude the global store's node groups in this
> function so that the subtopology ids and task ids are consecutive.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
