[
https://issues.apache.org/jira/browse/KAFKA-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263894#comment-16263894
]
ASF GitHub Bot commented on KAFKA-5631:
---------------------------------------
GitHub user umesh9794 opened a pull request:
https://github.com/apache/kafka/pull/4259
KAFKA-5631 : Use Jackson for serialising to JSON
This PR replaces the existing `Json.encode` to use Jackson serialization.
Since the change is spread more than one module, it relies on the existing
tests written for those modules.
If required, I can write new tests as well. Please suggest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/umesh9794/kafka KAFKA-5631
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4259
----
commit 87b2377e1262d09ebfdeb5237bf4b47e9f2a8cdc
Author: umesh chaudhary <umesh9...@gmail.com>
Date: 2017-11-23T06:45:42Z
KAFKA-5631
----
> Use Jackson for serialising to JSON
> -----------------------------------
>
> Key: KAFKA-5631
> URL: https://issues.apache.org/jira/browse/KAFKA-5631
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ismael Juma
> Assignee: Umesh Chaudhary
> Labels: newbie
> Fix For: 1.1.0
>
>
> We currently serialise to JSON via a manually written method `Json.encode`.
> The implementation is naive: it does a lot of unnecessary String
> concatenation and it doesn't handle escaping well.
> KAFKA-1595 switches to Jackson for parsing, so it would make sense to do this
> after that one is merged.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
