[ https://issues.apache.org/jira/browse/KAFKA-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219683#comment-16219683 ]
Kevin Lu commented on KAFKA-5991: --------------------------------- [~ijuma] [~junrao] [~becket_qin] I would like to work on this as my first code commit if this is a valid improvement. Would this change require a KIP as it touches metrics which are user-facing? Or do I just need to edit the existing KIP to reflect this change? > Change Consumer per partition lag metrics to put topic-partition-id in tags > instead of metric name > -------------------------------------------------------------------------------------------------- > > Key: KAFKA-5991 > URL: https://issues.apache.org/jira/browse/KAFKA-5991 > Project: Kafka > Issue Type: Improvement > Components: metrics > Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.0, 0.10.2.0, 0.11.0.0 > Reporter: Kevin Lu > Priority: Minor > Labels: metrics > > [KIP-92|https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer] > brought per partition lag metrics to {{KafkaConsumer}}, but these metrics > put the {{TOPIC-PARTITION_ID}} inside of the metric name itself. These > metrics should instead utilize the tags and put {{key="topic-partition"}} and > {{value=TOPIC-PARTITION_ID}}. > Per-broker (node) and per-topic metrics utilize tags in this way by putting > {{key="node/topic"}} and {{value=NODE_ID/TOPIC_NAME}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)