[
https://issues.apache.org/jira/browse/KAFKA-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216356#comment-16216356
]
ASF GitHub Bot commented on KAFKA-6105:
---------------------------------------
GitHub user cnZach opened a pull request:
https://github.com/apache/kafka/pull/4125
KAFKA-6105: load client properties in proper order for EndToEndLatency tool
Currently, the property file is loaded first, and later a auto generated
group.id is used:
consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" +
System.currentTimeMillis())
so even user gives the group.id in a property file, it is not picked up.
Change it to load client properties in proper order: set default values
first, then try to load the custom values set in client.properties file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cnZach/kafka cnZach_KAFKA-6105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4125
----
commit 448ea9df1f735da5362eb3204e9bd7a133516fb2
Author: Yuexin Zhang <zach.yx.zh...@gmail.com>
Date: 2017-10-24T05:48:04Z
load client properties in proper order: set default values first, then try
to load the custom values set in client.properties file
----
> group.id is not picked by kafka.tools.EndToEndLatency
> -----------------------------------------------------
>
> Key: KAFKA-6105
> URL: https://issues.apache.org/jira/browse/KAFKA-6105
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.11.0.0
> Reporter: Yuexin Zhang
>
> As per these lines:
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/EndToEndLatency.scala#L64-L67
> the property file is loaded first, and later a auto generated group.id is
> used:
> consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" +
> System.currentTimeMillis())
> so even user gives the group.id in a property file, it is not picked up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
