[ 
https://issues.apache.org/jira/browse/KAFKA-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207677#comment-16207677
 ] 

ASF GitHub Bot commented on KAFKA-6069:
---------------------------------------

GitHub user twbecker opened a pull request:

    https://github.com/apache/kafka/pull/4081

    KAFKA-6069: Properly tag KafkaStreams metrics with the client id.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twbecker/kafka KAFKA-6069

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4081
    
----
commit d97881df251674b4c7f3d3f9a270b4691dc262c4
Author: Tommy Becker <[email protected]>
Date:   2017-10-17T13:48:07Z

    Properly tag KafkaStreams metrics with the client id.

----


> Streams metrics tagged incorrectly
> ----------------------------------
>
>                 Key: KAFKA-6069
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6069
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Tommy Becker
>            Assignee: Tommy Becker
>            Priority: Minor
>
> KafkaStreams attempts to tag many (all?) of it's metrics with the client id. 
> But instead of retrieving the value from the config, it tags them with the 
> literal "client.id", as can be seen on 
> org/apache/kafka/streams/processor/internals/StreamsKafkaClient.java:114



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to