[
https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192956#comment-16192956
]
Rajini Sivaram commented on KAFKA-6011:
---------------------------------------
[~ewencp] Yes, It is odd to have both {{client-id=}} and {{id=}}, but the old
{{id=}} ones that are directly registered with JMX are being deprecated (at
least we have mentioned the deprecation in upgrade notes), so eventually we
will just have the client-id metrics. I am not sure anyone actually uses
different versions within a JVM, but it feels better to retain that flexibility
and avoid registering global metrics. It also keeps all the metrics registered
by a client together with consistent tags and allows these metrics to be
created and deleted easily without checking for other clients.
> AppInfoParser should only use metrics API and should not register JMX mbeans
> directly
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-6011
> URL: https://issues.apache.org/jira/browse/KAFKA-6011
> Project: Kafka
> Issue Type: Bug
> Components: metrics
> Reporter: Ewen Cheslack-Postava
> Priority: Minor
>
> AppInfoParser collects info about the app ID, version, and commit ID and logs
> them + exposes corresponding metrics. For some reason we ended up with the
> app ID metric being registered directly to JMX while the version and commit
> ID use the metrics API. This means the app ID would not be accessible to
> custom metrics reporter.
> This isn't a huge loss as this is probably a rarely used metric, but we
> should really only be using the metrics API. Only using the metrics API would
> also reduce and centralize the places we need to do name mangling to handle
> characters that might not be valid for metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
