[ 
https://issues.apache.org/jira/browse/KAFKA-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171662#comment-16171662
 ] 

Viliam Durina commented on KAFKA-5874:
--------------------------------------

Thanks for the fix. But it should not only check there's at least one command, 
but also that there are no unrecognized elements on command line.

> Incorrect command line handling
> -------------------------------
>
>                 Key: KAFKA-5874
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5874
>             Project: Kafka
>          Issue Type: Bug
>          Components: admin
>    Affects Versions: 0.10.2.0, 0.11.0.0
>         Environment: Probably unrelated, but Windows 10 in this case
>            Reporter: Viliam Durina
>            Assignee: huxihx
>            Priority: Minor
>
> Extra parameters on command line are silently ignored. This leads to 
> confusion. For example, I did this command:
> {{kafka-topics.bat --alter --topic my_topic partitions 3 --zookeeper 
> localhost}}
> Seemingly innocuous command took about 3 seconds and output nothing. It took 
> me a while to realize I missed "--" before "partitions", after which I got a 
> confirmation on output.
> Erroneous command lines should produce error output.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to