[
https://issues.apache.org/jira/browse/KAFKA-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169820#comment-16169820
]
ASF GitHub Bot commented on KAFKA-5919:
---------------------------------------
GitHub user ppatierno opened a pull request:
https://github.com/apache/kafka/pull/3887
KAFKA-5919: Delete records command "version" parameter ignored
Removed ignored "version" field in JSON file for deleting records
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppatierno/kafka kafka-5919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3887.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3887
----
commit ea9bd5e66ae746f1708ea961a049e6656d7eb72c
Author: Paolo Patierno <ppatie...@live.com>
Date: 2017-09-18T09:49:08Z
Removed ignored "version" field in JSON file for deleting records
----
> Delete records command "version" parameter ignored
> --------------------------------------------------
>
> Key: KAFKA-5919
> URL: https://issues.apache.org/jira/browse/KAFKA-5919
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Paolo Patierno
> Assignee: Paolo Patierno
> Priority: Minor
>
> Hi,
> the kafka-delete-records script allows user to pass information about records
> to delete through a JSON file. Such file, as described in the command help,
> is made by a "partitions" array and a "version" field. Reading
> [KIP-107|https://cwiki.apache.org/confluence/display/KAFKA/KIP-107%3A+Add+purgeDataBefore%28%29+API+in+AdminClient]
> and the DeleteRecords API (Key: 21) description it's not clear what such
> field is and even it's not used at all (in the current implementation).
> I'm going to remove it from tool help description and it should not need a
> KIP because today it's just ignored and even using a JSON file without
> "version" the tool just works.
> [~lindong] you implemented such delete command, are my considerations right ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
